cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Witschey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10415) Fix cqlsh bugs
Date Wed, 07 Oct 2015 21:58:26 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947679#comment-14947679
] 

Jim Witschey commented on CASSANDRA-10415:
------------------------------------------

These same tests fail on 3.0, so I'm making this ticket a subtask of CASSANDRA-10166 and setting
the fix version to rc2. These tests run on 3.0 on CassCI here:

http://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_cqlshlib/2/testReport/

> Fix cqlsh bugs
> --------------
>
>                 Key: CASSANDRA-10415
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10415
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jim Witschey
>            Assignee: Stefania
>              Labels: cqlsh
>             Fix For: 3.0.0 rc2
>
>
> This is followup to CASSANDRA-10289
> The tests currently failing should be:
> * {{cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_create_columnfamily}}
> ** uses {{create_columnfamily_table_template}}. Stefania says "the {{(}} after {{CREATE
... IF}} does not look valid to me."
> * {{cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_create_table}}
> ** uses {{create_columnfamily_table_template}}, see above.
> * {{cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_delete}}
> ** Stefania says: "I don't think keyspaces are a valid completion after {{DELETE a [}}
and after {{DELETE FROM twenty_rows_composite_table USING TIMESTAMP 0 WHERE TOKEN(a) >=}}.
From a quick analysis of {{cqlhandling.py}} I think it comes from {{<term>}}, which
picks up {{<functionName>}}, which was changed to include {{ks.}} by CASSANDRA-7556.
> * {{cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion.test_complete_in_drop_keyspace}}
> ** Stefania says: "the {{;}} after {{DROP KEYSPACE IF}} is not valid.
> * {{cqlshlib.test.test_cqlsh_output.TestCqlshOutput.test_timestamp_output}}
> ** already documented with CASSANDRA-10313 and CASSANDRA-10397
> I'm happy to break these out into separate tickets if necessary. 
> To run the tests locally, I cd to {{cassandra/pylib/cqlshlib}} and run the following:
> {code}
> ccm create -n 1 --install-dir=../.. test
> ccm start --wait-for-binary-proto
> nosetests test 2>&1
> ccm remove
> {code}
> This requires nose and ccm. Until CASSANDRA-10289 is resolved, you'll have to use my
branch here: https://github.com/mambocab/cassandra/tree/fix-cqlsh-tests
> Tests for this branch are run (non-continuously) here:
> http://cassci.datastax.com/job/scratch_mambocab-fix_cqlsh/
> Assigning [~Stefania] for now, since she's already looked at 10289, but feel free to
reassign.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message