cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10403) Consider reverting to CMS GC on 3.0
Date Thu, 08 Oct 2015 16:53:27 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948977#comment-14948977
] 

Joshua McKenzie commented on CASSANDRA-10403:
---------------------------------------------

I like the changes; having our GC settings in their own file cleans up quite a bit.

Some feedback:
* CMS is labeled as legacy and G1 as experimental. I'd remove the "legacy mode" label from
CMS since it's our recommended GC for 3.0 at this time
* Consider checking whether users have un-commented both GC types and alert / fail to start
on that configuration.
* Need to roll the .bat implementation back to CMS when you do the windows integration into
the .ps1. I'm fine not pursuing making the .bat file parse the jvm.options file since we strongly
recommend the .ps1 launch scripts and alert on lack of permissions to use them.

I'd like to see a follow-up ticket for 3.X where we unify all our JVM_OPTS in the jvm.options
file, not just GC statics (assuming your comment about GC statics wasn't just a typo: if you
mean JVM_OPTS statics I'm in complete agreement).

Looking good.

> Consider reverting to CMS GC on 3.0
> -----------------------------------
>
>                 Key: CASSANDRA-10403
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10403
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Config
>            Reporter: Joshua McKenzie
>            Assignee: Paulo Motta
>             Fix For: 3.0.0 rc2
>
>
> Reference discussion on CASSANDRA-7486.
> For smaller heap sizes G1 appears to have some throughput/latency issues when compared
to CMS. With our default max heap size at 8G on 3.0, there's a strong argument to be made
for having CMS as the default for the 3.0 release.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message