cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
Date Thu, 01 Oct 2015 16:12:28 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940022#comment-14940022
] 

Robert Stupp commented on CASSANDRA-10383:
------------------------------------------

Didn't look thoroughly at the patch/branch. But two things that I noticed:
* Thrift API is frozen and shouldn't be changed (especially no new features)
* APIs changed from 2.1/2.2 to 3.0+ and I guess that the patch cannot be merged cleanly from
2.1 via 2.1 to 3.0 and trunk. Can you provide a branch targeting 3.0, too?

However, the change itself looks trivial and generally fine to me.


> Disable auto snapshot on selected tables.
> -----------------------------------------
>
>                 Key: CASSANDRA-10383
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10383
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Tommy Stendahl
>            Assignee: Tommy Stendahl
>             Fix For: 2.1.x
>
>         Attachments: 10383.txt
>
>
> I have a use case where I would like to turn off auto snapshot for selected tables, I
don't want to turn it off completely since its a good feature. Looking at the code I think
it would be relatively easy to fix.
> My plan is to create a new table property named something like "disable_auto_snapshot".
If set to false it will prevent auto snapshot on the table, if set to true auto snapshot will
be controlled by the "auto_snapshot" property in the cassandra.yaml. Default would be true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message