cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Shopov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10031) Name threads for improved ops/debugging
Date Tue, 13 Oct 2015 08:12:06 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954592#comment-14954592
] 

Alexander Shopov commented on CASSANDRA-10031:
----------------------------------------------

Just some initial stats:
> At a minimum in the start of each run() method
I believe you mean all implementations of Runnable.run and Thread.start methods:
Whole project:
  Runnable.run: 198 occurrences
  Thread.start: 36 occurances
src/java:
  Runnable.run: 25 occurrences
  Thread.start: 19 occurances

The second numbers seem more representative and in need to be instrumented.



> Name threads for improved ops/debugging
> ---------------------------------------
>
>                 Key: CASSANDRA-10031
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10031
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: T Jake Luciani
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.x
>
>
> We currently provide basic names for threads in threads like {{STREAM-IN-1}}  which gives
some basic information about what the job of the thread is.  
> When looking at a log statement or jstack it's helpful to have this context.
> For our work stealing thread pool we share threads across all thread pools so we lose
this insight.  
> I'd like to propose we start using the Thread.currentThread().setName("")
> In different aspects of the code to improve insight as to what cassandra is doing at
any given moment.
>    * At a minimum in the start of each run() method.
>   Ideally for much finer grain things.
>    * In compaction include the partition name currently being working on.  
>    * In SP include the client ip
> Etc...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message