cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (CASSANDRA-9839) Move crc_check_chance out of compressions options
Date Fri, 16 Oct 2015 11:27:05 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benedict reopened CASSANDRA-9839:
---------------------------------

This patch introduced a strong self-reference leak inside of {{SegmentedFile}}. The anonymous
class that returns the check chance references the {{ColumnFamilyStore}} to provide the check
chance, which necessarily, eventually, references the {{SegmentedFile}} (through the {{Tracker}}'s
references to {{SSTableReader}}s)

> Move crc_check_chance out of compressions options
> -------------------------------------------------
>
>                 Key: CASSANDRA-9839
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9839
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Paulo Motta
>            Priority: Minor
>              Labels: client-impacting, docs-impacting
>             Fix For: 3.0.0 rc1
>
>
> Follow up to CASSANDRA-8384. The option doesn't belong to compression params - it doesn't
affect compression, itself, and isn't passed to compressors upon initialization.
> While it's true that it is (currently) only being honored when reading compressed sstables,
it still doesn't belong to compression params (and is causing CASSANDRA-7978 -like issues).
> [~tjake] suggested we should make it an option of its own, and I think we should.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message