Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 16 Sep 2015 16:54:45 +0000 (UTC)
From: "Benedict (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12863981.1442256369000.357084.1442422485935@Atlassian.JIRA>
In-Reply-To: <JIRA.12863981.1442256369000@Atlassian.JIRA>
References: <JIRA.12863981.1442256369000@Atlassian.JIRA>
 <JIRA.12863981.1442256369797@arcas>
Subject: [jira] [Commented] (CASSANDRA-10322) skipBytes is used extensively,
 but is slow
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790725#comment-14790725 ] 

Benedict commented on CASSANDRA-10322:
--------------------------------------

I booboo'd. I meant we do want to throw EOF, but that's regrettably _not_ compatible with {{skipBytes}} as defined by {{DataInput}} (which says clearly that it won't). We could change that, of course, but it's a possible razor to cut ourselves on later (even if very unlikely)

> skipBytes is used extensively, but is slow
> ------------------------------------------
>
>                 Key: CASSANDRA-10322
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10322
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Trivial
>             Fix For: 3.0.x
>
>
> We skip a great deal to avoid materializing data. Ironically, however, skipping is just as (perhaps more) expensive, as it allocates a temporary array of the size of the number of bytes we want to skip.
> This trivial patch implements {{skipBytes}} more efficiently, and simplifies {{FileUtils.skipBytesFully}}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)