Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA5AE17796 for ; Tue, 8 Sep 2015 21:25:41 +0000 (UTC) Received: (qmail 16997 invoked by uid 500); 8 Sep 2015 21:19:46 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 16961 invoked by uid 500); 8 Sep 2015 21:19:46 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 16903 invoked by uid 99); 8 Sep 2015 21:19:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2015 21:19:46 +0000 Date: Tue, 8 Sep 2015 21:19:46 +0000 (UTC) From: "Tyler Hobbs (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10261) Materialized Views Timestamp issues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735637#comment-14735637 ] Tyler Hobbs commented on CASSANDRA-10261: ----------------------------------------- I haven't given this a thorough review yet, but as quick feedback: * The serialization changes aren't backwards-compatible. They need to be conditional on {{version}}. * I'd go with Sylvain's suggestion of {{isWeak}} for the name on the flag. * It would be good to add base-table deletions to the mix in your unit test, where possible. I should have more complete feedback shortly. > Materialized Views Timestamp issues > ----------------------------------- > > Key: CASSANDRA-10261 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10261 > Project: Cassandra > Issue Type: Bug > Reporter: T Jake Luciani > Assignee: T Jake Luciani > Fix For: 3.0.0 rc1 > > > As [~thobbs] [mentioned|https://issues.apache.org/jira/browse/CASSANDRA-9664?focusedCommentId=14724150&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14724150] in CASSANDRA-9664 there are issues dealing with updates to individual cells which can mask data from the base table in the view when trying to filter data correctly in the view. > Unfortunately, this same issue exists for all MV tables with regular columns. > In the earlier versions of MV we did have a fix for this which I now can see is ineffective for all situations. > I've pushed some unit tests to show the issue (similar to tylers) and a fix. The idea is we keep the base table's timestamps per cell as it so we can *always* tell (per replica) which version of the record is the latest. Since the base table *always* writes the entire record to the view (part of our earlier partial fix) we can ensure the view record contains *at least* views primary key timestamp. -- This message was sent by Atlassian JIRA (v6.3.4#6332)