Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 14 Sep 2015 17:35:45 +0000 (UTC)
From: "Benedict (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12774977.1423851164000.332247.1442252145914@Atlassian.JIRA>
In-Reply-To: <JIRA.12774977.1423851164000@Atlassian.JIRA>
References: <JIRA.12774977.1423851164000@Atlassian.JIRA>
 <JIRA.12774977.1423851164889@arcas>
Subject: [jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only
 cancels compactions, which is not the only source of markCompacted
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743881#comment-14743881 ] 

Benedict commented on CASSANDRA-8805:
-------------------------------------

There wasn't a finally clause before, and it's currently being executed in all normal executions (whereas under failure it is discarded anyway), so I must admit I'm not certain what you're reasoning is. If you could elaborate I'd appreciate it.

> runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8805
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Carl Yeksigian
>             Fix For: 2.1.x
>
>         Attachments: 8805-2.1.txt
>
>
> Operations like repair that may operate over all sstables cancel compactions before beginning, and fail if there are any files marked compacting after doing so. Redistribution of index summaries is not a compaction, so is not cancelled by this action, but does mark sstables as compacting, so such an action will fail to initiate if there is an index summary redistribution in progress. It seems that IndexSummaryManager needs to register itself as interruptible along with compactions (AFAICT no other actions that may markCompacting are not themselves compactions).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)