cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10376) Fix upgrade_tests/paging_test.py:TestPagingData.static_columns_paging_test
Date Tue, 29 Sep 2015 10:09:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934955#comment-14934955
] 

Sylvain Lebresne commented on CASSANDRA-10376:
----------------------------------------------

Why don't we just change {{convertNamesFilterToSliceFilter}} to
{noformat}
if (requestedRows.isEmpty())
    slices = Slices.NONE;
else if (requestedRows.size() == 1 && requestedRows.first().size() == 0)
    slices = Slices.ALL;
{noformat}
I mean, converting a filter that selects no names to one that selects everything feels pretty
broken in the first place. Unless I'm forgetting some subtlety here.


> Fix upgrade_tests/paging_test.py:TestPagingData.static_columns_paging_test
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10376
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10376
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Aleksey Yeschenko
>            Assignee: Blake Eggleston
>             Fix For: 3.0.0 rc2
>
>
> Follow-up to CASSANDRA-10354 to fix the related upgrade issue.
> To quote [~bdeggleston]:
> {quote}
> So the failure is caused by an edge case where a names filter is used in a paging query
against a table that needs SinglePartitionNamesCommand instances converted to SinglePartitionSliceCommand
instances in order to be converted to legacy read commands.
> If the previous read returned all requested clusterings and a number of rows equal to
the page size, the subsequent read would have an empty clustering names filter. When an empty
clustering names filter is converted to a slice filter, the slice filter is created with Slices.ALL.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message