cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Blake Eggleston (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10354) Invalid paging with DISTINCT on static and IN
Date Fri, 18 Sep 2015 23:17:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876668#comment-14876668
] 

Blake Eggleston commented on CASSANDRA-10354:
---------------------------------------------

So the failure is caused by an edge case where a names filter is used in a paging query against
a table that needs SinglePartitionNamesCommand instances converted to SinglePartitionSliceCommand
instances in order to be converted to legacy read commands.

If the previous read returned all requested clusterings _and_ a number of rows equal to the
page size, the subsequent read would have an empty clustering names filter. When an empty
clustering names filter is converted to a slice filter, the slice filter is created with Slices.ALL.
I've added a flag to ClusteringNamesFilter that indicates it's empty, but was created from
another ClusteringNamesFilter that wasn't empty. If this flag is set, the slice filter is
created with Slices.NONE.

> Invalid paging with DISTINCT on static and IN
> ---------------------------------------------
>
>                 Key: CASSANDRA-10354
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10354
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 3.0.0 rc1
>
>
> Basically, the test from CASSANDRA-10352 happens to fail on 3.0, but not for the reason
in CASSANDRA-10352 but rather because it incorrectly return duplicate results. This is also
the reason for the failure of {{upgrade_tests/paging_test.py:TestPagingData.static_columns_paging_test}}
once that test doesn't run into CASSANDRA-10352 (which it currently does).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message