cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Lerer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10338) Secondary index large values dtest failing on 3.0
Date Fri, 18 Sep 2015 11:56:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14847312#comment-14847312
] 

Benjamin Lerer commented on CASSANDRA-10338:
--------------------------------------------

I do not know who fixed CASSANDRA-6237 but he effectively screwed up. ;-)

The patch will work for the LWT statements but will miss the other ones.
I think it is safer to put the check in {{ModificationStatement.buildPartitionKeyNames}}.
It is where the check was originally: https://github.com/apache/cassandra/blob/cassandra-2.2/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java#L319
 

> Secondary index large values dtest failing on 3.0
> -------------------------------------------------
>
>                 Key: CASSANDRA-10338
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10338
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>             Fix For: 3.0.0 rc1
>
>
> {{secondary_index_test:TestSecondaryIndex.test_8280_validate_indexed_values}} has been
failing since build [#147|http://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_dtest/147/].
The most likely cause is CASSANDRA-6237 (though I haven't confirmed that). 
> The problem is that if an oversized value is provided, the validation for LWT statements
(both regular and in batches) is not performed up front, but when the {{Cql3CasRequest}} is
executed via {{StorageProxy}}. This causes a timeout, rather than an immediate validation
error & hence the test fails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message