cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10322) skipBytes is used extensively, but is slow
Date Wed, 16 Sep 2015 16:44:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790702#comment-14790702
] 

Benedict commented on CASSANDRA-10322:
--------------------------------------

We can, although there is I think some value in not throwing EOF if we couldn't read enough
(which is typically what we want). We could do Options 1 _and_ 2: define a default method
{{skipBytesFully}} in {{DataInputPlus}} and migrate the EOF check there?

> skipBytes is used extensively, but is slow
> ------------------------------------------
>
>                 Key: CASSANDRA-10322
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10322
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Trivial
>             Fix For: 3.0.x
>
>
> We skip a great deal to avoid materializing data. Ironically, however, skipping is just
as (perhaps more) expensive, as it allocates a temporary array of the size of the number of
bytes we want to skip.
> This trivial patch implements {{skipBytes}} more efficiently, and simplifies {{FileUtils.skipBytesFully}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message