cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10301) Search for items past end of descending BTreeSearchIterator can fail
Date Mon, 14 Sep 2015 16:02:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743727#comment-14743727
] 

Benedict commented on CASSANDRA-10301:
--------------------------------------

Pushed an update with that addressed. It is clearer and should result in more compact byte
code to boot. Thanks

> Search for items past end of descending BTreeSearchIterator can fail
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-10301
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10301
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Blocker
>             Fix For: 3.0.0 rc1
>
>
> A very simple problem, but obvious and with simple fix once it is made apparent.
> The internal {{seekTo}} method uses {{binarySearch}} semantics for its return value,
however when searching backwards {{-1}} is a real value that should be returned to the client,
as it indicates "past the end" - so basing inexact matches from -1 leads to a conflicting
meaning, and so it gets misinterpreted. Rebasing inexact results to -2 fixes the problem.
> This was not caught because the randomized testing apparently did not test for values
outside the bounds of the btree. This has been fixed as well, and the tests did easily exhibit
the problem without the fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message