cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10109) Windows dtest 3.0: ttl_test.py failures
Date Thu, 03 Sep 2015 09:57:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728785#comment-14728785
] 

Stefania commented on CASSANDRA-10109:
--------------------------------------

bq.  In this case I felt the code came out significantly cleaner, but I don't feel strongly
about it.

That's fine, let's go for the cleaner option and have a single path.

bq. In the case of cleanup we have decided to abort and treat everything as "final" 

Not for the final record if you recall, we carry on in this case. The reasoning was that the
transaction had probably completed and we just crashed whilst writing the last record. So
even for cleaning up on startup there is a difference: previously a corrupt COMMIT would have
counted as a COMMIT and so that transaction would have been regarded as completed. Now it
is always considered in progress, which means we currently delete the new files rather than
the old files.

IMO any corruption we encounter when listing should be resolved with another read and if it
is still corrupt then we just ignore the txn file. I would also remove the special case of
the last record, if it is corrupt then on startup we also treat the txn file as corrupt and
leave everything as "final". We are basically more pessimistic but like you said the user
will have the error messages to work from after all.

> Windows dtest 3.0: ttl_test.py failures
> ---------------------------------------
>
>                 Key: CASSANDRA-10109
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10109
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Joshua McKenzie
>            Assignee: Stefania
>              Labels: Windows
>             Fix For: 3.0.0 rc1
>
>
> ttl_test.py:TestTTL.update_column_ttl_with_default_ttl_test2
> ttl_test.py:TestTTL.update_multiple_columns_ttl_test
> ttl_test.py:TestTTL.update_single_column_ttl_test
> Errors locally are different than CI from yesterday. Yesterday on CI we have timeouts
and general node hangs. Today on all 3 tests when run locally I see:
> {noformat}
> Traceback (most recent call last):
>   File "c:\src\cassandra-dtest\dtest.py", line 532, in tearDown
>     raise AssertionError('Unexpected error in %s node log: %s' % (node.name, errors))
> AssertionError: Unexpected error in node1 node log: ['ERROR [main] 2015-08-17 16:53:43,120
NoSpamLogger.java:97 - This platform does not support atomic directory streams (SecureDirectoryStream);
race conditions when loading sstable files could occurr']
> {noformat}
> This traces back to the commit for CASSANDRA-7066 today by [~Stefania] and [~benedict].
 Stefania - care to take this ticket and also look further into whether or not we're going
to have issues with 7066 on Windows? That error message certainly *sounds* like it's not a
good thing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message