cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9893) Fix upgrade tests from #9704 that are still failing
Date Fri, 04 Sep 2015 15:18:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730943#comment-14730943
] 

Sylvain Lebresne commented on CASSANDRA-9893:
---------------------------------------------

bq. it seems like the lesser of two evils

I'm still confused. What are the two evils, which one is better, and why do you think there
is no non-evil solutions? What I don't get is that this role manager is a tests only fix.
But if upgrade tests aren't working because the role manager freezes 3.0 nodes due to query
to 2.1 nodes, that will also be a problem when users upgrade, so we don't just want to fix
the tests, which seems to be what your suggestion does, we want to fix the source of the problem.
Unless you think it's only a problem for tests and won't be for users, but in that case it's
that last part I'm missing. Or maybe you are suggesting that users that upgrade should also
use that {{-Dcassandra.disable_default_role_setup}}?

In any case, I'm good with the rest of the fixes and I don't want to block everything on this,
so I've committed the other fixes and created CASSANDRA-10267 to focus on those paging tests.
If you still think that the role manager is the culprit, then can you provide more information
on that ticket and we'll go from there. I'm also closing this ticket since we've committed
something and let's open other, more focused ticket for whatever remaining upgrade_test still
fail on cassci.

> Fix upgrade tests from #9704 that are still failing
> ---------------------------------------------------
>
>                 Key: CASSANDRA-9893
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9893
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
>            Assignee: Blake Eggleston
>             Fix For: 3.0 beta 2
>
>
> The first things to do on this ticket would be to commit Tyler's branch (https://github.com/thobbs/cassandra-dtest/tree/8099-backwards-compat)
to the dtests so cassci run them. I've had to do a few minor modifications to have them run
locally so someone which access to cassci should do it and make sure it runs properly.
> Once we have that, we should fix any test that isn't passing. I've ran the tests locally
and I had 8 failures. for 2 of them, it sounds plausible that they'll get fixed by the patch
of CASSANDRA-9775, though that's just a guess.  The rest where test that timeouted without
a particular error in the log, and running some of them individually, they passed.  So we'll
have to see if it's just my machine being overly slow when running them all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message