cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-9893) Fix upgrade tests from #9704 that are still failing
Date Thu, 03 Sep 2015 14:36:46 GMT


Sylvain Lebresne commented on CASSANDRA-9893:

Ok, a few additional remarks on the last version:
* I'm not sure about the role manager skip. That is, I'm not really familiar with the role
manager at all, but from what you said it sounds like there is a problem with the role manager
in mixed-version cluster, in which case "let's skip it to make the tests pass" doesn't sound
like the right solution. Can you try to clarify what the problem is?
* In {{ReadCommand}}, I'm not sure about the use of {{allColumnsBuilder}} in {{LegacyRangeSliceCommandSerializer.getColumnSelectionForSlice()}}
and {{LegacyReadCommandSerializer.deserializeNamesSelectionAndFilter()}}. Even if that's what
they were doing, I think those are also wrong and should use {{selectionBuilder}}.  Basically,
{{allColumnsBuilder}} is a 3.0 thing for efficiency but there is not real reason it should
be used in any backward compatibility case.
* I don't think we should change {{noRowsIterator}} at all: as it stands, your addition of
a parameters (the static columns) is unused in the method.

> Fix upgrade tests from #9704 that are still failing
> ---------------------------------------------------
>                 Key: CASSANDRA-9893
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
>            Assignee: Blake Eggleston
>             Fix For: 3.0 beta 2
> The first things to do on this ticket would be to commit Tyler's branch (
to the dtests so cassci run them. I've had to do a few minor modifications to have them run
locally so someone which access to cassci should do it and make sure it runs properly.
> Once we have that, we should fix any test that isn't passing. I've ran the tests locally
and I had 8 failures. for 2 of them, it sounds plausible that they'll get fixed by the patch
of CASSANDRA-9775, though that's just a guess.  The rest where test that timeouted without
a particular error in the log, and running some of them individually, they passed.  So we'll
have to see if it's just my machine being overly slow when running them all.

This message was sent by Atlassian JIRA

View raw message