cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9738) Migrate key-cache to be fully off-heap
Date Sun, 13 Sep 2015 21:20:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742670#comment-14742670
] 

Benedict commented on CASSANDRA-9738:
-------------------------------------

bq. In a lot of cases the RIE is going to be enclosed by a Closable iterator anyways.

Given our historically poor handling of resource release, and how many nooks and crannies
they end up in now, I'd prefer we didn't depend on the closure of iterators until we have
some better facilities in place for catching leaks, like CASSANDRA-9918. Right now I don't
think we're likely to leak much on a per-request/leak basis (just prevent some shared cleanup,
per discarded major resource, such as an sstable) if we fail to close an iterator. So this
could magnify the effect of any such bug.

> Migrate key-cache to be fully off-heap
> --------------------------------------
>
>                 Key: CASSANDRA-9738
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9738
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>             Fix For: 3.0.0 rc1
>
>
> Key cache still uses a concurrent map on-heap. This could go to off-heap and feels doable
now after CASSANDRA-8099.
> Evaluation should be done in advance based on a POC to prove that pure off-heap counter
cache buys a performance and/or gc-pressure improvement.
> In theory, elimination of on-heap management of the map should buy us some benefit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message