cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9632) Preserve the Names of Query Parameters in QueryOptions
Date Tue, 15 Sep 2015 17:20:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745773#comment-14745773
] 

Sam Tunnicliffe commented on CASSANDRA-9632:
--------------------------------------------

+1 the new patch LGTM (sorry it took so long to review). 
The only comment I'd make would be that you should probably rebase & push 2.2/3.0/trunk
versions for CI before committing.

> Preserve the Names of Query Parameters in QueryOptions
> ------------------------------------------------------
>
>                 Key: CASSANDRA-9632
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9632
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: stephen mallette
>            Assignee: Benjamin Lerer
>            Priority: Minor
>             Fix For: 2.2.x
>
>         Attachments: 9632-2.2-V2.txt, 9632-2.2.txt
>
>
> When writing a custom {{QueryHandler}} that processes named parameters, the {{QueryOptions}}
arrive to the various processing methods with the values converted to positional arguments
and the names unavailable.  A custom {{QueryHandler}} might want to make use of the names
themselves so it would be helpful if they were preserved and exposed with their respective
{{ByteBuffer}} values.
> https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/cql3/QueryOptions.java#L205



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message