cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8821) Errors in JVM_OPTS and cassandra_parms environment vars
Date Fri, 25 Sep 2015 16:10:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908248#comment-14908248
] 

Eric Evans commented on CASSANDRA-8821:
---------------------------------------

[~mshuler]:

{{debian/init}}:
This is all a throwback to when the init script used {{jsvc}}, and there is a bit more of
it that can be excised; You can also remove the bits that source {{cassandra-env.sh}}, and
the zero-length test of {{$JVM_OPTS}}. See: CASSANDRA-10251.

{{conf/cassandra-env.\{sh,ps1\}}}:
I don't think we should be promoting the use of {{JVM_EXTRA_OPTS}} from within {{cassandra-env.*}}.
 By which I mean, if you are editing one of those files then it's probably sanest to just
edit {{JVM_OPTS}}, and leave {{JVM_EXTRA_OPTS}} as a way of injecting options from elsewhere.
 I suggest that we remove the commented out assignment, adjust the documenting comments accordingly,
or remove them entirely.  You can put a commented out  {{JVM_EXTRA_OPTS}} assignment, and
corresponding documentation in {{debian/default}}.

Does this sounds reasonable?

> Errors in JVM_OPTS and cassandra_parms environment vars
> -------------------------------------------------------
>
>                 Key: CASSANDRA-8821
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8821
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: Ubuntu 14.04 LTS amd64
>            Reporter: Terry Moschou
>            Assignee: Michael Shuler
>            Priority: Minor
>             Fix For: 2.1.x, 2.2.x
>
>         Attachments: 8821_2.0.txt, 8821_2.1.txt
>
>
> Repos:
> deb http://www.apache.org/dist/cassandra/debian 21x main
> deb-src http://www.apache.org/dist/cassandra/debian 21x main
> The cassandra init script
>   /etc/init.d/cassandra
> is sourcing the environment file
>   /etc/cassandra/cassandra-env.sh
> twice. Once directly from the init script, and again inside
>   /usr/sbin/cassandra
> The result is arguments in JVM_OPTS are duplicated.
> Further the JVM opt
>   -XX:CMSWaitDuration=10000
> is defined twice if jvm >= 1.7.60.
> Also, for the environment variable CASSANDRA_CONF used in this context
>   -XX:CompileCommandFile=$CASSANDRA_CONF/hotspot_compiler"
> is undefined when
>   /etc/cassandra/cassandra-env.sh
> is sourced from the init script.
> Lastly the variable cassandra_storagedir is undefined in
>   /usr/sbin/cassandra
> when used in this context
>   -Dcassandra.storagedir=$cassandra_storagedir



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message