cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
Date Sun, 13 Sep 2015 23:13:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742717#comment-14742717
] 

Benedict commented on CASSANDRA-8805:
-------------------------------------

Thanks. I've pushed a version [here|https://github.com/belliottsmith/cassandra/tree/8805],
which just cleans up ever so slightly.

As a note for the future, it's very helpful for review to avoid squashing until after we're
ready to commit (or we reach some mutually agreed way point)

> runWithCompactionsDisabled only cancels compactions, which is not the only source of
markCompacted
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8805
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Carl Yeksigian
>             Fix For: 2.1.x
>
>         Attachments: 8805-2.1.txt
>
>
> Operations like repair that may operate over all sstables cancel compactions before beginning,
and fail if there are any files marked compacting after doing so. Redistribution of index
summaries is not a compaction, so is not cancelled by this action, but does mark sstables
as compacting, so such an action will fail to initiate if there is an index summary redistribution
in progress. It seems that IndexSummaryManager needs to register itself as interruptible along
with compactions (AFAICT no other actions that may markCompacting are not themselves compactions).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message