cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Branimir Lambov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8143) Partitioner should not be accessed through StorageService
Date Fri, 04 Sep 2015 17:07:48 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731063#comment-14731063
] 

Branimir Lambov commented on CASSANDRA-8143:
--------------------------------------------

I have also been tempted to do one of the three. However, none of them would actually solve
anything, leaving an actual problem to lurk instead of being addressed. The particular issue
at hand is that accessing {{Schema.instance}} from client-mode tools is an error.

As far as I can see from the CASSANDRA-9839 patch description, the patch is not supposed to
do this in client mode. I believe the thing you need to do is to move the two {{\[id\]file.setCrcCheckChanceSupplier(cfs::getCrcCheckChance);}}
from {{setup()}} to {{setupOnline()}}.

While you are doing this, you may want to use the opportunity to fix an omission of mine:
add a comment or assertion message to {{CFMetaData.java:278}} to specifically mention that
this failure is probably due to accessing {{Schema.instance}} from client-mode tools with
a pointer to this ticket. Apologies for forgetting to do that myself.

> Partitioner should not be accessed through StorageService
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-8143
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8143
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Branimir Lambov
>            Assignee: Branimir Lambov
>             Fix For: 3.0 beta 1
>
>
> The configured partitioner is no longer the only partitioner in use in the database,
as e.g. index tables use LocalPartitioner.
> To make sure the correct partitioner is used for each table, accesses of StorageService.getPartitioner()
should be replaced with retrieval of the CFS-specific partitioner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message