cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-7918) Provide graphing tool along with cassandra-stress
Date Wed, 30 Sep 2015 17:27:05 GMT


Joshua McKenzie commented on CASSANDRA-7918:

Squashed your commits and touched up some style nits while reviewing - pushed [here|]

Patch looks solid. I didn't go in-depth reviewing the .html file included, but as for the
java side I have a couple of outstanding questions:
* MultiPrintStream has quite a few non-overridden base (write*/print*) methods that would
allow writing to the base stream without writing to the additional streams. I'd recommend
we override all print/write methods to make them multiStream compatible.
* In StressAction, the following looks incorrect to me:
if (settings.rate.minThreads > 0)
   output.println("Thread count was not specified, testing multiple thread counts");
settings.rate.minThreads looks to indicate our preferred min thread-count which that output
message contradicts.

Just about good to commit once we get those two minor things ironed out. Thanks for sticking
with this!

> Provide graphing tool along with cassandra-stress
> -------------------------------------------------
>                 Key: CASSANDRA-7918
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Benedict
>            Assignee: Ryan McGuire
>            Priority: Minor
>         Attachments: 7918.txt, reads.svg
> Whilst cstar makes some pretty graphs, they're a little limited and also require you
to run your tests through it. It would be useful to be able to graph results from any stress
run easily.

This message was sent by Atlassian JIRA

View raw message