Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BDF8018FE3 for ; Thu, 13 Aug 2015 19:17:50 +0000 (UTC) Received: (qmail 87205 invoked by uid 500); 13 Aug 2015 19:17:47 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 87173 invoked by uid 500); 13 Aug 2015 19:17:47 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 87162 invoked by uid 99); 13 Aug 2015 19:17:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Aug 2015 19:17:46 +0000 Date: Thu, 13 Aug 2015 19:17:46 +0000 (UTC) From: "Paulo Motta (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9917) MVs should validate gc grace seconds on the tables involved MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695796#comment-14695796 ] Paulo Motta commented on CASSANDRA-9917: ---------------------------------------- so, if I understood correctly, we want to validate on CreateMVStatement if baseTable.gcGraceSeconds < MIN_GC_GRACE_SECONDS, and also on AlterTableStatement if baseTable.NewGcGraceSeconds < MIN_GC_GRACE_SECONDS, is that correct? I will assume this is the case, please let me know if I should validate in the actual write instead. > MVs should validate gc grace seconds on the tables involved > ----------------------------------------------------------- > > Key: CASSANDRA-9917 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9917 > Project: Cassandra > Issue Type: Bug > Reporter: Aleksey Yeschenko > Assignee: Paulo Motta > Labels: materializedviews > Fix For: 3.0.0 rc1 > > > For correctness reasons (potential resurrection of dropped values), batchlog entries are TTLs with the lowest gc grace second of all the tables involved in a batch. > It means that if gc gs is set to 0 in one of the tables, the batchlog entry will be dead on arrival, and never replayed. > We should probably warn against such LOGGED writes taking place, in general, but for MVs, we must validate that gc gs on the base table (and on the MV table, if we should allow altering gc gs there at all), is never set too low, or else. -- This message was sent by Atlassian JIRA (v6.3.4#6332)