Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7889B18237 for ; Mon, 17 Aug 2015 16:26:10 +0000 (UTC) Received: (qmail 83528 invoked by uid 500); 17 Aug 2015 16:25:48 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 83486 invoked by uid 500); 17 Aug 2015 16:25:48 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 83471 invoked by uid 99); 17 Aug 2015 16:25:47 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Aug 2015 16:25:47 +0000 Date: Mon, 17 Aug 2015 16:25:47 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9749) CommitLogReplayer continues startup after encountering errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699778#comment-14699778 ] Jonathan Ellis commented on CASSANDRA-9749: ------------------------------------------- bq. Due to CASSANDRA-8515, the effective commit log failure policy in 3.0+ at time of replay is always 'die'. Hmm, was that intended? /cc [~pauloricardomg] [~benedict] > CommitLogReplayer continues startup after encountering errors > ------------------------------------------------------------- > > Key: CASSANDRA-9749 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9749 > Project: Cassandra > Issue Type: Bug > Reporter: Blake Eggleston > Assignee: Branimir Lambov > Fix For: 2.2.x > > Attachments: 9749-coverage.tgz > > > There are a few places where the commit log recovery method either skips sections or just returns when it encounters errors. > Specifically if it can't read the header here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L298 > Or if there are compressor problems here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L314 and here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L366 > Whether these are user-fixable or not, I think we should require more direct user intervention (ie: fix what's wrong, or remove the bad file and restart) since we're basically losing data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)