Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 31 Aug 2015 16:31:47 +0000 (UTC)
From: "Branimir Lambov (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12835710.1433509627000.211941.1441038707969@Atlassian.JIRA>
In-Reply-To: <JIRA.12835710.1433509627000@Atlassian.JIRA>
References: <JIRA.12835710.1433509627000@Atlassian.JIRA>
 <JIRA.12835710.1433509627533@arcas>
Subject: [jira] [Commented] (CASSANDRA-9554) Avoid digest mismatch storm on
 upgrade to 3.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723641#comment-14723641 ] 

Branimir Lambov commented on CASSANDRA-9554:
--------------------------------------------

Thank you, the new test looks great.

Nit in [the addRowDeletion comment|https://github.com/pcmanus/cassandra/commit/e0699a4451980d1b568e3e0ec960851b7d58ad4c#diff-79b0ff76cc67b62a0d7947248e60c379R152]: s/use to/used to/

+1, commit when cassci's happy.

> Avoid digest mismatch storm on upgrade to 3.0
> ---------------------------------------------
>
>                 Key: CASSANDRA-9554
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9554
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Sylvain Lebresne
>              Labels: upgrade
>             Fix For: 3.0 beta 2
>
>
> CASSANDRA-8099, in {{UnfilteredRowIterators.digest()}}:
> {code}
>         // TODO: we're not computing digest the same way that old nodes. This
>         // means we'll have digest mismatches during upgrade. We should pass the messaging version of
>         // the node this is for (which might mean computing the digest last, and won't work
>         // for schema (where we announce the version through gossip to everyone))
> {code}
> In a mixed 2.1(2.2) - 3.0 clusters, we need to calculate both digest at the same time and keep both results, and send the appropriate one, depending on receiving nodes' messaging versions. Do that until {{MessagingService.allNodesAtLeast30()}} is true (this is not unprecedented).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)