Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 36BA9180BB for ; Wed, 12 Aug 2015 22:00:47 +0000 (UTC) Received: (qmail 54925 invoked by uid 500); 12 Aug 2015 22:00:47 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 54898 invoked by uid 500); 12 Aug 2015 22:00:46 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 54831 invoked by uid 99); 12 Aug 2015 22:00:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Aug 2015 22:00:46 +0000 Date: Wed, 12 Aug 2015 22:00:46 +0000 (UTC) From: "Daniel Chia (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9265) Add checksum to saved cache files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694255#comment-14694255 ] Daniel Chia commented on CASSANDRA-9265: ---------------------------------------- Yes the channel should be closed by the `close()` method of ChecksummedRandomAccessReader, so I don't see why this is a leak. > Add checksum to saved cache files > --------------------------------- > > Key: CASSANDRA-9265 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9265 > Project: Cassandra > Issue Type: Improvement > Reporter: Ariel Weisberg > Assignee: Daniel Chia > Fix For: 2.2.1, 3.0 beta 1 > > Attachments: 0001-Add-checksum-to-saved-cache-files-CASSANDRA-9265.patch, 0002-trunk-CASSANDRA-9265.patch > > > Saved caches are not covered by a checksum. We should at least emit a checksum. My suggestion is a large checksum of the whole file (convenient offline validation), and then smaller per record checksums after each record is written (possibly a subset of the incrementally maintained larger checksum). > I wouldn't go for anything fancy to try to recover from corruption since it is just a saved cache. If corruption is detected while reading I would just have it bail out. I would rather have less code to review and test in this instance. -- This message was sent by Atlassian JIRA (v6.3.4#6332)