Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9F9E5174F6 for ; Sun, 9 Aug 2015 13:15:47 +0000 (UTC) Received: (qmail 73233 invoked by uid 500); 9 Aug 2015 13:15:46 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 73164 invoked by uid 500); 9 Aug 2015 13:15:46 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 72961 invoked by uid 99); 9 Aug 2015 13:15:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Aug 2015 13:15:46 +0000 Date: Sun, 9 Aug 2015 13:15:46 +0000 (UTC) From: "Aleksey Yeschenko (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679136#comment-14679136 ] Aleksey Yeschenko commented on CASSANDRA-7342: ---------------------------------------------- The original patch was ignoring {{shouldHint}} in {{commitPaxos()}} when the node was live. Both the original patch and my follow-up had redundant methods - and arguments - we don't need an extra {{isCas}} or {{kind}} fields in {{WriteCallbackInfo}} because we can infer the type from {{sentMessage.verb}}. Updated versions: [2.1|https://github.com/iamaleksey/cassandra/tree/7342-2.1], [2.2|https://github.com/iamaleksey/cassandra/tree/7342-2.2], [3.0|https://github.com/iamaleksey/cassandra/tree/7342-3.0]. Cassci: [2.1 testall|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-2.1-testall/], [2.1 dtest|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-2.1-dtest/], [2.2 testall|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-2.2-testall/], [2.2 dtest|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-2.2-dtest/], [3.0 testall|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-3.0-testall/], [3.0 dtest|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-3.0-dtest/]. > CAS writes does not have hint functionality. > --------------------------------------------- > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Sub-task > Reporter: sankalp kohli > Assignee: sankalp kohli > Fix For: 2.1.x, 2.2.x, 3.0.x > > Attachments: 7342_2.0.txt, 7342_2.1.txt > > > When a dead node comes up, it gets the last commit but not anything which it has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)