Return-Path: 
 <commits-return-140309-apmail-cassandra-commits-archive=cassandra.apache.org@cassandra.apache.org>
X-Original-To: apmail-cassandra-commits-archive@www.apache.org
Delivered-To: apmail-cassandra-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id AC82818E0F
	for <apmail-cassandra-commits-archive@www.apache.org>;
 Wed,  5 Aug 2015 15:16:08 +0000 (UTC)
Received: (qmail 51705 invoked by uid 500); 5 Aug 2015 15:16:08 -0000
Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org
Received: (qmail 51670 invoked by uid 500); 5 Aug 2015 15:16:08 -0000
Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cassandra.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cassandra.apache.org>
List-Post: <mailto:commits@cassandra.apache.org>
List-Id: <commits.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list commits@cassandra.apache.org
Received: (qmail 51655 invoked by uid 99); 5 Aug 2015 15:16:08 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Aug 2015 15:16:08 +0000
Date: Wed, 5 Aug 2015 15:16:08 +0000 (UTC)
From: "Marcus Olsson (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12630778.1360019633000.378534.1438787768441@Atlassian.JIRA>
In-Reply-To: <JIRA.12630778.1360019633000@Atlassian.JIRA>
References: <JIRA.12630778.1360019633000@Atlassian.JIRA>
 <JIRA.12630778.1360019633971@arcas>
Subject: [jira] [Commented] (CASSANDRA-5220) Repair improvements when using
 vnodes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CASSANDRA-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658349#comment-14658349 ] 

Marcus Olsson commented on CASSANDRA-5220:
------------------------------------------

Created a pull request [here|https://github.com/stef1927/cassandra/pull/2] to your branch.

Most comments should've been fixed but there was one in particular I wasn't 100% sure about. In _RepairJobDesc.java_ in the _deserialize()_ method:
{quote}
// CR-TODO is it safe to use the MS.globalPartitioner() here?
range = (Range<Token>) AbstractBounds.tokenSerializer.deserialize(in,
                        MessagingService.globalPartitioner(), version);
{quote}
Not sure what to use instead, but I guess it should be safe since the trunk version uses it.

> Repair improvements when using vnodes
> -------------------------------------
>
>                 Key: CASSANDRA-5220
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5220
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Brandon Williams
>            Assignee: Marcus Olsson
>              Labels: performance, repair
>         Attachments: 5220-yourkit.png, 5220-yourkit.tar.bz2, cassandra-3.0-5220-1.patch, cassandra-3.0-5220-2.patch, cassandra-3.0-5220.patch
>
>
> Currently when using vnodes, repair takes much longer to complete than without them.  This appears at least in part because it's using a session per range and processing them sequentially.  This generates a lot of log spam with vnodes, and while being gentler and lighter on hard disk deployments, ssd-based deployments would often prefer that repair be as fast as possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)