cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10189) Unify read/writeUTF code paths
Date Thu, 27 Aug 2015 17:01:46 GMT


Benedict commented on CASSANDRA-10189:

bq. Certainly on the fast path we can and should eliminate the extra allocations. But I'm
not sure it's worth dabbling with unsafe unless we can predictably avoid a lot of allocations

I was referring to the zero-copy allocation for the large strings. I should have made clearer
that I completely agree for small strings.

> Unify read/writeUTF code paths
> ------------------------------
>                 Key: CASSANDRA-10189
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
> (Follow-up to CASSANDRA-9738 and CASSANDRA-8670)
> CASSANDRA-9738 requires {{writeUTF}} functionality that has been improved in CASSANDRA-8670
plus {{readUTF}} functionality. But we need slightly different signatures - one taking {{DataInput}}/{{DataOutput}}
and one taking {{ByteBuffer}}.
> We can combine both code paths and benefit from a shared, thread-local byte buffer.
> Slightly different implementations are needed for array backed and direct BBs (as we
can directly access the backing array bypassing the direct BB's boundary checks).
> (Part of this has already been done for CASSANDRA-9738 in {{OHCKeyCache.SerializationUtil}})

This message was sent by Atlassian JIRA

View raw message