cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Thompson (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-10066) Bring cqlsh into PEP8 compliance
Date Mon, 31 Aug 2015 18:59:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723868#comment-14723868
] 

Philip Thompson edited comment on CASSANDRA-10066 at 8/31/15 6:59 PM:
----------------------------------------------------------------------

One important change I want to point out is at https://github.com/apache/cassandra/compare/trunk...ptnapoleon:10066-2.2#diff-1cce67f7d76864f07aaf4d986d6fc051R2303
. 2.1 is already using self.hostname, which appears to be the correct behavior.

The new import ordering was determined using isort. https://github.com/timothycrosley/isort


was (Author: philipthompson):
One important change I want to point out is at https://github.com/apache/cassandra/compare/trunk...ptnapoleon:10066-2.2#diff-1cce67f7d76864f07aaf4d986d6fc051R2303
. 2.1 is already using self.hostname, which appears to be the correct behavior.

> Bring cqlsh into PEP8 compliance
> --------------------------------
>
>                 Key: CASSANDRA-10066
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10066
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Philip Thompson
>            Assignee: Philip Thompson
>            Priority: Minor
>              Labels: cqlsh
>             Fix For: 3.x, 2.1.x, 2.2.x
>
>
> In order for us to begin running flake8 against cqlsh.py in CI, it would be helpful if
it were already PEP8 complaint, with the exception of using 120 character lines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message