cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10046) RangeTombstone validation missing on thrift
Date Mon, 24 Aug 2015 12:49:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709205#comment-14709205
] 

Sylvain Lebresne commented on CASSANDRA-10046:
----------------------------------------------

Seems the upgrade tests have been reverted for now since they are posing problem on cassci.

Now, I would suggest that we please review and commit this _without_ waiting on those tests.
In a perfect world, I would agree waiting on those test would be nice, but in the meantime
I'd like to really focus on fixing all outstanding dtests because people are creating dtests
regression faster than they are fixed and the only solution to stop the bleeding is probably
to get all dtests to pass (so people stop being lazy at checking dtests and see they own regressions
before commit).  

> RangeTombstone validation missing on thrift
> -------------------------------------------
>
>                 Key: CASSANDRA-10046
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10046
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: T Jake Luciani
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 3.0.0 rc1
>
>
> Currently a number of thrift tests fail due to a NPE
> {code}
> test_range_deletion 
> test_batch_mutate_remove_slice_standard
> test_batch_mutate_remove_slice_of_entire_supercolumns
> {code}
> These errors all stem from the fact we aren't properly throwing a validation exception
when a deletion with a slice that is not start == finish.  
> We should add better validation to throw a clear exception sooner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message