cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10006) 2.1 format sstable filenames with "tmp" are not handled by 3.0
Date Mon, 10 Aug 2015 00:17:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679420#comment-14679420
] 

Stefania commented on CASSANDRA-10006:
--------------------------------------

Thanks Jeremiah.

I've attached a patch that supports 2.1 files as well. The temporary files are deleted at
startup when we detect a version upgrade; this was already in place but for 2.2 files only.
I've also used regular expressions to make the match as accurate as possible.

CI still pending:

http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10006-3.0-testall/
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10006-3.0-dtest/



> 2.1 format sstable filenames with "tmp" are not handled by 3.0
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-10006
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10006
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Tyler Hobbs
>            Assignee: Stefania
>             Fix For: 3.0 beta 1
>
>
> In 3.0, {{Descriptor.fromFilename()}} doesn't handle "tmp" in sstable filenames in the
2.1 (ka) format.  If you start 3.0 with one of these filenames, you'll see an exception like
the following:
> {noformat}
> ERROR [main] 2015-08-05 10:15:57,872 CassandraDaemon.java:623 - Exception encountered
during startup
> java.lang.AssertionError: Invalid file name system-schema_columns-tmp-ka-5-Filter.db
in /tmp/dtest-Jstsy2/test/node1/data/system/schema_columns-296e9c049bec3085827dc17d3df2122a
>     at org.apache.cassandra.io.sstable.Descriptor.fromFilename(Descriptor.java:291) ~[main/:na]
>     at org.apache.cassandra.io.sstable.Descriptor.fromFilename(Descriptor.java:190) ~[main/:na]
>     at org.apache.cassandra.service.StartupChecks$7$1.visitFile(StartupChecks.java:226)
~[main/:na]
>     at org.apache.cassandra.service.StartupChecks$7$1.visitFile(StartupChecks.java:218)
~[main/:na]
>     at java.nio.file.Files.walkFileTree(Files.java:2670) ~[na:1.8.0_45]
>     at java.nio.file.Files.walkFileTree(Files.java:2742) ~[na:1.8.0_45]
>     at org.apache.cassandra.service.StartupChecks$7.execute(StartupChecks.java:251) ~[main/:na]
>     at org.apache.cassandra.service.StartupChecks.verify(StartupChecks.java:103) ~[main/:na]
>     at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:163) [main/:na]
>     at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:504)
[main/:na]
>     at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:610) [main/:na]
> {noformat}
> I can reliably reproduce this with an [upgrade dtest|https://github.com/thobbs/cassandra-dtest/blob/8099-backwards-compat/upgrade_tests/cql_tests.py#L5126-L5162]
from CASSANDRA-9704, but it should also be reproducible by simply starting 3.0 with a filename
like the one from the error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message