cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9985) Introduce our own AbstractIterator
Date Wed, 05 Aug 2015 20:50:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658893#comment-14658893
] 

Ariel Weisberg commented on CASSANDRA-9985:
-------------------------------------------

Can you use the AbstractIterator test from Guava on this? It's a chance to check for any gotchas
they may have come across and quietly engineered around. 

Can I bring up the icache boogyman? Guava appears to have two AbstractIterator implementations.
One in base and one in collect?

Maybe what we want is to replace Guava's abstract iterator(s) by putting it in their package?

> Introduce our own AbstractIterator
> ----------------------------------
>
>                 Key: CASSANDRA-9985
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9985
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Trivial
>             Fix For: 3.0.0 rc1
>
>
> The Guava AbstractIterator not only has unnecessary method call depth, it is difficult
to debug without attaching source. Since it's absolutely trivial to write our own, and it's
used widely within the codebase, I think we should do so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message