cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9985) Introduce our own AbstractIterator
Date Fri, 07 Aug 2015 06:27:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661392#comment-14661392
] 

Benedict commented on CASSANDRA-9985:
-------------------------------------

Right, it seems exceedingly difficult to get into, and is a worse misuse of the iterator than
the iterator can handle. 

My main reason to not want to address it, though, is that we will be stepping through this
{{AbstractIterator.hasNext()}} often, and I'd like it to be easy and attractive to do so.
I had a quick go at making it remain easy to read and, hopefully, step through, while still
catching this edge case. I've pushed a version that I think meets the criteria.

> Introduce our own AbstractIterator
> ----------------------------------
>
>                 Key: CASSANDRA-9985
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9985
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Trivial
>             Fix For: 3.0.0 rc1
>
>
> The Guava AbstractIterator not only has unnecessary method call depth, it is difficult
to debug without attaching source. Since it's absolutely trivial to write our own, and it's
used widely within the codebase, I think we should do so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message