cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9962) WaitQueueTest is flakey
Date Wed, 05 Aug 2015 14:52:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658318#comment-14658318
] 

Ariel Weisberg commented on CASSANDRA-9962:
-------------------------------------------

My bad. I looked at the bottom part of the diff and it doesn't show how wait queue separates
registration from waiting.

+1

> WaitQueueTest is flakey
> -----------------------
>
>                 Key: CASSANDRA-9962
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9962
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 3.x
>
>
> While the test is a little noddy, and superfluous, it shouldn't fail even vanishingly
infrequently. [~aweisberg] has spotted it doing so, and I have also encountered it once, so
I suspect that a change in hardware/OS may have made vanishingly unlikely just pretty unlikely,
which is even less good. 
> Right now it depends on {{Thread.start()}} completing before the new thread starts; this
isn't guaranteed. This patch fixes that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message