cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9932) Make all partitions btree backed
Date Tue, 11 Aug 2015 06:57:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681333#comment-14681333
] 

Benedict commented on CASSANDRA-9932:
-------------------------------------

Hmm. I filtered that out because I knew the related code hadn't changed since it was first
written, and I knew it failed due to OOM.

It is completely benign and a test failure, however (and if you fix it, it still fails against
default heap with OOM). It simply requires a non-null {{UpdateFunction}}. I've fixed, pushed,
and am running a lengthy burn test run for security.

> Make all partitions btree backed
> --------------------------------
>
>                 Key: CASSANDRA-9932
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9932
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>             Fix For: 3.0.0 rc1
>
>
> Following on from the other btree related refactors, this patch makes all partition (and
partition-like) objects backed by the same basic structure: {{AbstractBTreePartition}}. With
two main offshoots: {{ImmutableBTreePartition}} and {{AtomicBTreePartition}}
> The main upshot is a 30% net code reduction, meaning better exercise of btree code paths
and fewer new code paths to go wrong. A secondary upshort is that, by funnelling all our comparisons
through a btree, there is a higher likelihood of icache occupancy and we have only one area
to focus delivery of improvements for their enjoyment by all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message