cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9932) Make all partitions btree backed
Date Tue, 11 Aug 2015 00:22:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681003#comment-14681003
] 

Ariel Weisberg commented on CASSANDRA-9932:
-------------------------------------------

testOversizedMiddleInsert still fails with a 4 gigabyte heap.

{code}
LongBTreeTest
org.apache.cassandra.utils.LongBTreeTest
testOversizedMiddleInsert(org.apache.cassandra.utils.LongBTreeTest)
java.lang.NullPointerException
	at org.apache.cassandra.utils.btree.BTree.buildInternal(BTree.java:134)
	at org.apache.cassandra.utils.btree.BTree.build(BTree.java:97)
	at org.apache.cassandra.utils.LongBTreeTest.testOversizedMiddleInsert(LongBTreeTest.java:603)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:44)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
	at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
{code}

> Make all partitions btree backed
> --------------------------------
>
>                 Key: CASSANDRA-9932
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9932
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>             Fix For: 3.0.0 rc1
>
>
> Following on from the other btree related refactors, this patch makes all partition (and
partition-like) objects backed by the same basic structure: {{AbstractBTreePartition}}. With
two main offshoots: {{ImmutableBTreePartition}} and {{AtomicBTreePartition}}
> The main upshot is a 30% net code reduction, meaning better exercise of btree code paths
and fewer new code paths to go wrong. A secondary upshort is that, by funnelling all our comparisons
through a btree, there is a higher likelihood of icache occupancy and we have only one area
to focus delivery of improvements for their enjoyment by all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message