cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Blake Eggleston (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9893) Fix upgrade tests from #9704 that are still failing
Date Mon, 31 Aug 2015 18:45:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723847#comment-14723847
] 

Blake Eggleston commented on CASSANDRA-9893:
--------------------------------------------

The {{TestCQL.conditional_delete_test}} failure is caused by the interaction of two LegacyLayout
behaviors. First, the static row is always prepended to the LegacyCell iterator here: https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/LegacyLayout.java#L646.
Second, the ColumnFilter instance deserialized from a 2.1 read command always has isFetchAll
set to true. This may be more of a ColumnFilter.Builder problem, which sets isFetchAll to
true if CFMetaData is present here: https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L291

In any case, this causes the static cells to be passed back to the 2.1 node as part of the
read response. I've added a 'maybeDisableFetchAll' method to the column filter builder, which
is called from the legacy slice command deserializer, and turns off isFetchAll if the command
isn't selecting all regular/static columns. This fixes the issue, and doesn't break anything
else, but I'm not positive this is the best way to fix the problem. https://github.com/bdeggleston/cassandra/commit/5bacd62b7a6492cc91a8fd33846ea3a7d3ef9dfc

The {{TestPagingWithDeletions.test_failure_threshold_deletions}} failure was caused by an
out of date log regex, which is fixed here: https://github.com/bdeggleston/cassandra-dtest/commit/28de3d11fe355a5289e70f38cb8e9e9d010a8059

I've also found these 2 tests, which are failing sporadically:
cql_tests:TestCQL.static_columns_cas_test
TestPagingSize.test_with_equal_results_to_page_size

> Fix upgrade tests from #9704 that are still failing
> ---------------------------------------------------
>
>                 Key: CASSANDRA-9893
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9893
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
>            Assignee: Blake Eggleston
>             Fix For: 3.0 beta 2
>
>
> The first things to do on this ticket would be to commit Tyler's branch (https://github.com/thobbs/cassandra-dtest/tree/8099-backwards-compat)
to the dtests so cassci run them. I've had to do a few minor modifications to have them run
locally so someone which access to cassci should do it and make sure it runs properly.
> Once we have that, we should fix any test that isn't passing. I've ran the tests locally
and I had 8 failures. for 2 of them, it sounds plausible that they'll get fixed by the patch
of CASSANDRA-9775, though that's just a guess.  The rest where test that timeouted without
a particular error in the log, and running some of them individually, they passed.  So we'll
have to see if it's just my machine being overly slow when running them all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message