cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-9749) CommitLogReplayer continues startup after encountering errors
Date Mon, 17 Aug 2015 17:06:48 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699822#comment-14699822
] 

Ariel Weisberg edited comment on CASSANDRA-9749 at 8/17/15 5:06 PM:
--------------------------------------------------------------------

I remember that conversation as well. Part of that was making an effort to distinguish between
expected failures (end of log) and unexpected ones. I think there is going to be some pain
there because it's really hard to tell the two apart.

I am not dead set against stop as a default behavior for replay, I just don't think linking
the two settings together -isn't- is a good idea.

Extra negatives were not intentional.


was (Author: aweisberg):
I remember that conversation as well. Part of that was making an effort to distinguish between
expected failures (end of log) and unexpected ones. I think there is going to be some pain
there because it's really hard to tell the two apart.

I am not dead set against stop as a default behavior for replay, I just don't think linking
the two settings together -isn't- a good idea.

Extra negatives were not intentional.

> CommitLogReplayer continues startup after encountering errors
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-9749
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9749
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Branimir Lambov
>             Fix For: 2.2.x
>
>         Attachments: 9749-coverage.tgz
>
>
> There are a few places where the commit log recovery method either skips sections or
just returns when it encounters errors.
> Specifically if it can't read the header here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L298
> Or if there are compressor problems here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L314
and here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L366
> Whether these are user-fixable or not, I think we should require more direct user intervention
(ie: fix what's wrong, or remove the bad file and restart) since we're basically losing data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message