cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9712) Refactor CFMetaData
Date Sat, 01 Aug 2015 20:58:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650529#comment-14650529
] 

Robert Stupp commented on CASSANDRA-9712:
-----------------------------------------

CachingOptions had two allowed syntaxes: map and (deprecated) string. Is it intentional that
the string syntax is removed? These changes should be included in NEWS.txt. Deprecation of
CompressionParams’ SSTABLE_COMPRESSION and CHUNK_LENGTH_KB, should be mentioned in NEWS.txt,
too.

CompactionParams.validate(): catch of InvocationTargetException and IllegalAccessException
should include the original cause to ConfigurationException.
(CompressionParams.validate() does that.)

ColumnFamilyStore.setCompactionStrategyClass() seems not to actually set the new compaction
strategy in CFS.
ColumnFamiliyStore.setCompressionParameters() should validate the params before these are
actually applied.
LongCompactionsTest.defineSchema(): compactionOptions.put() is redundant (that test fails
for this reason)

Utests look good (except the one mentioned above). Dtests run failed.

Nits:
* SpeculativeRetryParam: remove none() + all() (or just return the constant) - but I'd be
fine with leaving it as it is.
* CompressionParams: use „public static final“ instead of „public final static“ (and
for private/volatile)
* ReplicationParams.CLASS is not final


> Refactor CFMetaData
> -------------------
>
>                 Key: CASSANDRA-9712
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9712
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>             Fix For: 3.x
>
>
> As part of CASSANDRA-9425 and a follow-up to CASSANDRA-9665, and a pre-requisite for
new schema change protocol, this ticket will do the following
> 1. Make the triggers {{HashMap}} immutable (new {{Triggers}} class)
> 2. Allow multiple 2i definitions per column in CFMetaData
> 3. <to be filled in>
> 4. Rename and move {{config.CFMetaData}} to {{schema.TableMetadata}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message