cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Branimir Lambov (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-9554) Avoid digest mismatch storm on upgrade to 3.0
Date Thu, 27 Aug 2015 09:00:51 GMT


Branimir Lambov commented on CASSANDRA-9554:

Patch looks good, but apart from dtests I'd like to see at least some minimal unit testing:
* a version of {{PartitionTest.testDigest}} for pre-3.0 version,
* as the old digest will not change in the future, something that compares the result of calling
digest with old version parameter to a precomputed value. We shouldn't need to go to dtests
to catch trivial regressions in the calculation.

> Avoid digest mismatch storm on upgrade to 3.0
> ---------------------------------------------
>                 Key: CASSANDRA-9554
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Sylvain Lebresne
>              Labels: upgrade
>             Fix For: 3.0 beta 2
> CASSANDRA-8099, in {{UnfilteredRowIterators.digest()}}:
> {code}
>         // TODO: we're not computing digest the same way that old nodes. This
>         // means we'll have digest mismatches during upgrade. We should pass the messaging
version of
>         // the node this is for (which might mean computing the digest last, and won't
>         // for schema (where we announce the version through gossip to everyone))
> {code}
> In a mixed 2.1(2.2) - 3.0 clusters, we need to calculate both digest at the same time
and keep both results, and send the appropriate one, depending on receiving nodes' messaging
versions. Do that until {{MessagingService.allNodesAtLeast30()}} is true (this is not unprecedented).

This message was sent by Atlassian JIRA

View raw message