cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-9265) Add checksum to saved cache files
Date Wed, 12 Aug 2015 22:51:46 GMT


Aleksey Yeschenko commented on CASSANDRA-9265:

Committed as [85d550f9460ce763acb97ad0740f6ea495f911d3|]
to cassandra-2.2 and merged into cassandra-3.0/trunk (not going through cassci b/c there is
just no way a patch this minor can break things, and, more importantly, the task queue is
currently insane).

> Add checksum to saved cache files
> ---------------------------------
>                 Key: CASSANDRA-9265
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ariel Weisberg
>            Assignee: Daniel Chia
>             Fix For: 2.2.1, 3.0 beta 1
>         Attachments: 0001-Add-checksum-to-saved-cache-files-CASSANDRA-9265.patch, 0002-trunk-CASSANDRA-9265.patch,
9265-2.2.txt, 9265-3.0.txt
> Saved caches are not covered by a checksum. We should at least emit a checksum. My suggestion
is a large checksum of the whole file (convenient offline validation), and then smaller per
record checksums after each record is written (possibly a subset of the incrementally maintained
larger checksum).
> I wouldn't go for anything fancy to try to recover from corruption since it is just a
saved cache. If corruption is detected while reading I would just have it bail out. I would
rather have less code to review and test in this instance.

This message was sent by Atlassian JIRA

View raw message