cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9232) "timestamp" is considered as a reserved keyword in cqlsh completion
Date Mon, 17 Aug 2015 09:18:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699243#comment-14699243
] 

Stefania commented on CASSANDRA-9232:
-------------------------------------

The patches are here:

https://github.com/stef1927/cassandra/commits/9232-2.1
https://github.com/stef1927/cassandra/commits/9232-2.2
https://github.com/stef1927/cassandra/commits/9232-3.0
https://github.com/stef1927/cassandra/commits/9232

We lost *materialized* and *view* from the reserved keywords in 3.0 and trunk, I've opened
[PYTHON-380|https://datastax-oss.atlassian.net/browse/PYTHON-380] for this. Shall I also add
them to the cassandra-test branch and update the python driver in 3.0 and trunk?

CI is running, I'll check the results tomorrow:

http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9232-testall	
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9232-dtest	
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9232-3.0-testall	
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9232-3.0-dtest		 
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9232-2.2-testall 
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9232-2.2-dtest	
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9232-2.1-testall	
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-9232-2.1-dtest


> "timestamp" is considered as a reserved keyword in cqlsh completion
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-9232
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9232
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Michaël Figuière
>            Assignee: Stefania
>            Priority: Trivial
>              Labels: cqlsh
>             Fix For: 3.x, 2.1.x
>
>
> cqlsh seems to treat "timestamp" as a reserved keyword when used as an identifier:
> {code}
> cqlsh:ks1> create table t1 (int int primary key, ascii ascii, bigint bigint, blob
blob, boolean boolean, date date, decimal decimal, double double, float float, inet inet,
text text, time time, timestamp timestamp, timeuuid timeuuid, uuid uuid, varchar varchar,
varint varint);
> {code}
> Leads to the following completion when building an {{INSERT}} statement:
> {code}
> cqlsh:ks1> insert into t1 (int, 
> "timestamp" ascii       bigint      blob        boolean     date        decimal     double
     float       inet        text        time        timeuuid    uuid        varchar     varint
> {code}
> "timestamp" is a keyword but not a reserved one and should therefore not be proposed
as a quoted string. It looks like this error happens only for timestamp. Not a big deal of
course, but it might be worth reviewing the keywords treated as reserved in cqlsh, especially
with the many changes introduced in 3.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message