cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6434) Repair-aware gc grace period
Date Mon, 10 Aug 2015 17:59:47 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680453#comment-14680453
] 

Yuki Morishita commented on CASSANDRA-6434:
-------------------------------------------

Patch looks good to me.
testall seems OK, waiting for another dtest run to make sure.

Little more comments on new unit test (RepairedDataTombstoneTest) will be helpful. There is
commented lines in the test that I guess it's just for seeing data and can be removed.

I think it is good to add brief lines in NEWS.txt's new feature section about this functionality
before you commit.


> Repair-aware gc grace period 
> -----------------------------
>
>                 Key: CASSANDRA-6434
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6434
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: sankalp kohli
>            Assignee: Marcus Eriksson
>             Fix For: 3.0 beta 1
>
>
> Since the reason for gcgs is to ensure that we don't purge tombstones until every replica
has been notified, it's redundant in a world where we're tracking repair times per sstable
(and repairing frequentily), i.e., a world where we default to incremental repair a la CASSANDRA-5351.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message