cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Olsson (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-5220) Repair improvements when using vnodes
Date Wed, 05 Aug 2015 15:16:08 GMT


Marcus Olsson commented on CASSANDRA-5220:

Created a pull request [here|] to your branch.

Most comments should've been fixed but there was one in particular I wasn't 100% sure about.
In _RepairJobDesc.java_ in the _deserialize()_ method:
// CR-TODO is it safe to use the MS.globalPartitioner() here?
range = (Range<Token>) AbstractBounds.tokenSerializer.deserialize(in,
                        MessagingService.globalPartitioner(), version);
Not sure what to use instead, but I guess it should be safe since the trunk version uses it.

> Repair improvements when using vnodes
> -------------------------------------
>                 Key: CASSANDRA-5220
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Brandon Williams
>            Assignee: Marcus Olsson
>              Labels: performance, repair
>         Attachments: 5220-yourkit.png, 5220-yourkit.tar.bz2, cassandra-3.0-5220-1.patch,
cassandra-3.0-5220-2.patch, cassandra-3.0-5220.patch
> Currently when using vnodes, repair takes much longer to complete than without them.
 This appears at least in part because it's using a session per range and processing them
sequentially.  This generates a lot of log spam with vnodes, and while being gentler and lighter
on hard disk deployments, ssd-based deployments would often prefer that repair be as fast
as possible.

This message was sent by Atlassian JIRA

View raw message