Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3AEB7185C5 for ; Thu, 23 Jul 2015 12:48:05 +0000 (UTC) Received: (qmail 99285 invoked by uid 500); 23 Jul 2015 12:48:05 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 99249 invoked by uid 500); 23 Jul 2015 12:48:05 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 99234 invoked by uid 99); 23 Jul 2015 12:48:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2015 12:48:05 +0000 Date: Thu, 23 Jul 2015 12:48:05 +0000 (UTC) From: "Sylvain Lebresne (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (CASSANDRA-9705) Simplify some of 8099's concrete implementations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne resolved CASSANDRA-9705. ----------------------------------------- Resolution: Fixed Yes, there were a few small problems with reading old sstables. I should have run those tests but I forgot sorry. Anyway, took the liberty to directly fix those in commit [f713be4a|https://git1-us-west.apache.org/repos/asf?p=cassandra.git;a=commitdiff;h=f713be4a], so closing again (if you still find upgrade tests that are broken, feel free to re-open, but in that case please point me to which test is failing exactly cause the upgrade tests I've used are all passing). > Simplify some of 8099's concrete implementations > ------------------------------------------------ > > Key: CASSANDRA-9705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9705 > Project: Cassandra > Issue Type: Sub-task > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Fix For: 3.0 beta 1 > > > As mentioned in the ticket comments, some of the concrete implementations (for Cell, Row, Clustering, PartitionUpdate, ...) of the initial patch for CASSANDRA-8099 are more complex than they should be (the use of flyweight is typically probably ill-fitted), which probably has performance consequence. This ticket is to track the refactoring/simplifying those implementation (mainly by removing the use of flyweights and simplifying accordingly). -- This message was sent by Atlassian JIRA (v6.3.4#6332)