Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D8C118F25 for ; Mon, 6 Jul 2015 10:26:06 +0000 (UTC) Received: (qmail 22224 invoked by uid 500); 6 Jul 2015 10:26:05 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 22197 invoked by uid 500); 6 Jul 2015 10:26:05 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 22147 invoked by uid 99); 6 Jul 2015 10:26:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2015 10:26:05 +0000 Date: Mon, 6 Jul 2015 10:26:05 +0000 (UTC) From: "Branimir Lambov (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9656) Strong circular-reference leaks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614837#comment-14614837 ] Branimir Lambov commented on CASSANDRA-9656: -------------------------------------------- The 2.1 version looks good. In the 2.2 (Branch 9656-2.2 I presume? Your second link points to the same place.), {{testFileRemoval}} no longer does truncation at the end, and the earlier version of {{testSSTableSplit}} checks that a truncation is not actually performed in the offline case, while it now skips that call altogether-- if that's a required change, [this comment|https://github.com/apache/cassandra/compare/trunk...belliottsmith:9656-2.2#diff-02c4b3ac06af7b36bb219956c41616f6R707] should be changed. The rest looks good. > Strong circular-reference leaks > ------------------------------- > > Key: CASSANDRA-9656 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9656 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Benedict > Assignee: Benedict > Priority: Critical > Fix For: 2.1.8 > > > As discussed in CASSANDRA-9423, we are leaking references to the ref-counted object into the Ref.Tidy, so that they remain strongly reachable, significantly limiting the value of the leak detection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)