Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 16 Jul 2015 10:21:04 +0000 (UTC)
From: "Benedict (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12781602.1426190879000.203818.1437042064903@Atlassian.JIRA>
In-Reply-To: <JIRA.12781602.1426190879000@Atlassian.JIRA>
References: <JIRA.12781602.1426190879000@Atlassian.JIRA>
 <JIRA.12781602.1426190879315@arcas>
Subject: [jira] [Commented] (CASSANDRA-8963) Make OpOrder more intuitive
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629529#comment-14629529 ] 

Benedict commented on CASSANDRA-8963:
-------------------------------------

bq. But if that's not possible

It's not, it's pretty fundamental to correctness in the memtable case.

bq. the actual usages of the class are barely documented.

Sure, I'll address that

bq.  delaying it post-3.0 because I really think this can wait.

We _need_ the functionality of "MultiPhaseOp". "RestartableOp" "SynchronizingOp" or whatever we call it in 3.0 for secondary index changes. We could just deliver it by itself, but I had hoped this would be reasonably easy to mark this whole item off our TODO list at the same time. If comments and naming are the only point of contention, I think that's still achievable, since I've pretty much agreed to rollover and accept whatever names [~JoshuaMcKenzie] decides on after my last comments.

This change also gives us some greater safety against misuse, and the easy addition of further safety. Given the number of potentially scary changes around OpOrder usage post-8099 (the latest incarnation of which I've still not personally reviewed, since they were changed immediately preceding the 8099 commit), that is also likely of value. 

bq. Hopefully the actual suggestion of my comment are not totally waste of time however.

Not at all. I'll be sure to use it.

> Make OpOrder more intuitive
> ---------------------------
>
>                 Key: CASSANDRA-8963
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8963
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 3.x
>
>
> There has been plenty of feedback about OpOrder being unintuitive. As well as revisiting the naming, I propose to introduce an Action object with RAII (AutoCloseable) protection that should be more obvious to users of the API. We can also then protect this by a Ref instance for use cases where the action lifetime is illdefined, and perhaps also introduce some checks for actions whose lifetimes extend beyond a sensible limit to report those where the object reference is retained.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)