cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9880) ScrubTest.testScrubOutOfOrder should generate test file on the fly
Date Thu, 30 Jul 2015 00:01:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646941#comment-14646941
] 

Stefania commented on CASSANDRA-9880:
-------------------------------------

I am not an expert with the new API either but it looks correct, so +1. 

I created a [pull request|https://github.com/yukim/cassandra/pull/1] with some, mostly unrelated,
suggestions:

- keepOriginals in scrubber is not used
- there is a BAD RELEASE error in sstable.validate(), if you are not comfortable committing
this just open another ticket, exception details below
- there is a slightly more compact API taken from fillCF().

{code}
ERROR 23:46:59 BAD RELEASE: attempted to release a reference (org.apache.cassandra.utils.concurrent.Ref$State@59662a93)
that has already been released
ERROR 23:46:59 Allocate trace org.apache.cassandra.utils.concurrent.Ref$State@59662a93:
Thread[main,5,main]
  at java.lang.Thread.getStackTrace(Thread.java:1552)
  at org.apache.cassandra.utils.concurrent.Ref$Debug.<init>(Ref.java:218)
  at org.apache.cassandra.utils.concurrent.Ref$State.<init>(Ref.java:148)
  at org.apache.cassandra.utils.concurrent.Ref.<init>(Ref.java:70)
  at org.apache.cassandra.io.sstable.format.SSTableReader.<init>(SSTableReader.java:215)
  at org.apache.cassandra.io.sstable.format.big.BigTableReader.<init>(BigTableReader.java:57)
  at org.apache.cassandra.io.sstable.format.big.BigFormat$ReaderFactory.open(BigFormat.java:103)
  at org.apache.cassandra.io.sstable.format.SSTableReader.internalOpen(SSTableReader.java:600)
  at org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:464)
  at org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:362)
  at org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:357)
  at org.apache.cassandra.db.ScrubTest.testScrubOutOfOrder(ScrubTest.java:349)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:497)
  at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
  at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
  at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
  at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
  at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
  at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
  at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
  at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:44)
  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
  at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
  at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
  at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
  at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
  at org.junit.runner.JUnitCore.run(JUnitCore.java:159)
  at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78)
  at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212)
  at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:497)
  at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)

ERROR 23:46:59 Deallocate trace org.apache.cassandra.utils.concurrent.Ref$State@59662a93:
Thread[main,5,main]
  at java.lang.Thread.getStackTrace(Thread.java:1552)
  at org.apache.cassandra.utils.concurrent.Ref$Debug.deallocate(Ref.java:224)
  at org.apache.cassandra.utils.concurrent.Ref$State.release(Ref.java:203)
  at org.apache.cassandra.utils.concurrent.Ref.release(Ref.java:87)
  at org.apache.cassandra.io.sstable.format.SSTableReader.validate(SSTableReader.java:1254)
  at org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:482)
  at org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:362)
  at org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:357)
  at org.apache.cassandra.db.ScrubTest.testScrubOutOfOrder(ScrubTest.java:349)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:497)
  at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
  at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
  at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
  at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
  at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
  at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
  at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
  at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:44)
  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
  at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
  at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
  at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
  at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
  at org.junit.runner.JUnitCore.run(JUnitCore.java:159)
  at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78)
  at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212)
  at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:497)
  at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
{code}

> ScrubTest.testScrubOutOfOrder should generate test file on the fly
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-9880
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9880
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Blocker
>              Labels: test-failure
>             Fix For: 3.0 beta 1
>
>
> ScrubTest#testScrubOutOfOrder is failing on trunk due to the serialization format change
from pre-generated out-of-order SSTable.
> We should change that to generate out-of-order SSTable on the fly so that we don't need
to bother generating SSTable by hand again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message