cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9828) Minor improvements to RowStats
Date Thu, 16 Jul 2015 07:50:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629380#comment-14629380
] 

Sylvain Lebresne commented on CASSANDRA-9828:
---------------------------------------------

The branch with the commits is [here|https://github.com/pcmanus/cassandra/commits/9828]. It's
on top of CASSANDRA-9705 for reasons similar to the one of CASSANDRA-9801, so the branch is
reviewable, but I'm cool if we wait for CASSANDRA-9705 to go in before actually reviewing.

> Minor improvements to RowStats
> ------------------------------
>
>                 Key: CASSANDRA-9828
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9828
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 3.0 beta 1
>
>
> There is some small improvements/refactor I'd like to do for {{RowStats}}. More specifically,
I'm attaching 3 commits:
> # the first one merely rename {{RowStats}} to {{EncodingStats}}. {{RowStats}} was not
a terribly helpful name while {{EncodingStats}} at least give a sense of why the thing exists.
> # the 2nd one improve the serialization of those {{EncodingStats}}. {{EncodingStats}}
holds both a {{minTimestamp}} and a {{minLocalDeletionTime}}, both of which are unix timestamp
(or at least should be almost all the time for the timestamp by convention) and so are fairly
big numbers that don't get much love (if any) from vint encoding. So the patch introducing
hard-coded epoch numbers for both that roughly correspond to now, and substract that to the
actual {{EncodingStats}} number to make it more rip for vint encoding. It does mean the exact
encoding size will deteriorate over time, but it'll take a while before it becomes useless
and we'll probably have more more change to the encodings by then anyway (and/or we can change
the epoch number regularly with new versions of the messaging protocol if we so wish).
> # the last patch is just a small simple cleanup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message